Initial check-in of CoRE-MOF notebook#75
Conversation
There was a problem hiding this comment.
Can you please add to the ReadMe some information about the dependency required, the Author. I can see there is some of this info in the Notebook itself, but it would be nice to have it in the ReadMe so folk can see it when they open the folder in github
There was a problem hiding this comment.
Look better? While you're here, I see sonarcloud found a problem that I don't really think is a problem, but no idea how to tell it that - any ideas?
There was a problem hiding this comment.
I agree its not an issue, we can formally accept it, but its not blocking merging now
There was a problem hiding this comment.
Aye, I've accepted the issue, as it does not apply to this.
There was a problem hiding this comment.
Doesn't the notebook need PACMANCharges? I'd just add it under a requirements header
There was a problem hiding this comment.
I've added in the requirement for PACMAN charge
|
I think you might need to add a commit with NO_JIRA for the CCDC PR checks to be happy |
|
3 participants
No description provided.